Project

General

Profile

Robert Mustacchi's activity

From 2020-04-24 to 2020-05-23

2020-05-23

02:52 PM illumos gate Bug #11668: libproc(3LIB) typo in proc_get_auxv
Review at https://code.illumos.org/c/illumos-gate/+/697. Robert Mustacchi
02:51 PM illumos gate Feature #12763: ixgbe ufm support
Review at https://code.illumos.org/c/illumos-gate/+/684. Robert Mustacchi
02:51 PM illumos gate Feature #12762: topo should create per-device UFM entries by default
Review at https://code.illumos.org/c/illumos-gate/+/683. Robert Mustacchi
02:51 PM illumos gate Feature #12761: i40e should only register ufm data on func 0
Review at https://code.illumos.org/c/illumos-gate/+/682. Robert Mustacchi
02:51 PM illumos gate Bug #12765: fwflash plugin cleanup handling is buggy
Review at https://code.illumos.org/c/illumos-gate/+/681. Robert Mustacchi
02:51 PM illumos gate Feature #12760: igb ufm support
Review at https://code.illumos.org/c/illumos-gate/+/681. Robert Mustacchi
02:51 PM illumos gate Bug #12758: ufm_detach doesn't properly clean up
Review at https://code.illumos.org/c/illumos-gate/+/681. Robert Mustacchi
02:50 PM illumos gate Feature #12759: Want ability to read ufm images
Review at https://code.illumos.org/c/illumos-gate/+/681. Robert Mustacchi
02:49 PM illumos gate Feature #12689: Want c11 uchar.h
Review at https://code.illumos.org/c/illumos-gate/+/643. Robert Mustacchi
02:48 PM illumos gate Feature #12685: ddi_create_minor_node() should take const char * values
Review was at https://code.illumos.org/c/illumos-gate/+/638. Robert Mustacchi
02:42 PM illumos gate Feature #12685: ddi_create_minor_node() should take const char * values
Josh also tested this for me by going through and booting up a system with a USB keyboard on the wscons and successfu... Robert Mustacchi
06:00 AM illumos gate Bug #12778 (Closed): typo in proc_arg_grab(3PROC)
Robert Mustacchi
05:56 AM illumos gate Bug #12778: typo in proc_arg_grab(3PROC)
While this is a dup of 11902, I've gone through and taken care of all the additional feedback there. Thanks Ryan. Robert Mustacchi

2020-05-22

11:32 PM illumos gate Feature #12685: ddi_create_minor_node() should take const char * values
To test this I plugged in a usb keyboard and usb mouse and attached a bunch of virtual IP-KVM services to a system (t... Robert Mustacchi
11:00 PM illumos gate Feature #12772: Need support for BCM57406 in bnxe
Unfortunately the bnxe driver and the bnxt driver are actually rather different. This'll require a new driver. While ... Robert Mustacchi

2020-05-20

08:24 PM illumos gate Bug #12768: 12392 regressed ftello64 behavior
To test this I wrote some additional regression tests and reran the libc test suite:... Robert Mustacchi
04:37 PM illumos gate Bug #12768 (Closed): 12392 regressed ftello64 behavior
In 12392 I refactored a bit of the way that the ftell code was implemented to try and centralize that. Unfortunately,... Robert Mustacchi
01:54 AM illumos gate Bug #12765 (New): fwflash plugin cleanup handling is buggy
The @fwflash@ program has two different options for clean up handling. By default it will handle it itself, otherwise... Robert Mustacchi

2020-05-19

08:41 PM illumos gate Feature #12763 (New): ixgbe ufm support
To make it easier to read ixgbe's eeprom, we should add ufm support to ixgbe. Unfortunately the 82599 EEPROM map and ... Robert Mustacchi
08:35 PM illumos gate Feature #12762 (New): topo should create per-device UFM entries by default
In the original implementation of the UFM subsystem, UFM entries in topo showed up on a per-PCI function basis by def... Robert Mustacchi
08:25 PM illumos gate Feature #12761 (New): i40e should only register ufm data on func 0
Today, i40e reports a UFM entry on all of its instances. However, the UFM it represents is device wide and in fact it... Robert Mustacchi
08:23 PM illumos gate Feature #12760 (New): igb ufm support
It'd be nice to enable support for ufm information in igb and allowing us to read the igb eeprom. This change works w... Robert Mustacchi
08:16 PM illumos gate Feature #12759 (New): Want ability to read ufm images
The UFM subsystem today has the ability to report information about modules. We've envisioned that it should be able ... Robert Mustacchi
08:16 PM illumos gate Bug #12758 (New): ufm_detach doesn't properly clean up
While iterating on some ufm related issues, I noticed that the ufm_attach(9E) was failing. The attach routine is very... Robert Mustacchi
08:09 PM illumos gate Bug #12755: Double fault when booting under Amazon EC2
So I agree double checking things is useful and in the face of a bunch of hypervisor games we should do anyways. But ... Robert Mustacchi
07:58 PM illumos gate Bug #12755: Double fault when booting under Amazon EC2
OK. I'd be curious to understand more as the on_fault/no_fault logic in the CMI MSR code should cause us to return wi... Robert Mustacchi
07:42 PM illumos gate Bug #12755: Double fault when booting under Amazon EC2
Can you share which of the MSRs it's emulating or not emulating as expected there? I would have expected them not to ... Robert Mustacchi

2020-05-15

06:06 PM illumos gate Bug #12739: gld module missing dep on mac after 12671
This was tested by Aurélien who verified that with the fix in place the vboxnet module correctly loaded. Robert Mustacchi
03:08 PM illumos gate Bug #12739 (Closed): gld module missing dep on mac after 12671
12671 swapped most callers from the older @hcksum_*@ routines to @mac_hcksum_*@ routines. While most of the module de... Robert Mustacchi

2020-05-11

09:22 PM illumos gate Bug #12686: dladm: vnic creation over bge0 failed: object already exists
Ultimately we've been able to conclude that the earlier analysis was correct. This was introduced as a side effect of... Robert Mustacchi
09:06 PM illumos gate Bug #12713 (Closed): Network error after udating to 2020.04 / bge0: DL_BIND_REQ failed
Robert Mustacchi
09:05 PM illumos gate Bug #12713: Network error after udating to 2020.04 / bge0: DL_BIND_REQ failed
Hi Sven, thanks for providing that. Based on this, I can pretty clearly say that this is the same problem as in 12686... Robert Mustacchi
02:50 PM illumos gate Bug #12713: Network error after udating to 2020.04 / bge0: DL_BIND_REQ failed
Hi Sven, For the DTrace bits to be useful, it'd really help to run them while doing the ipadm enable if. That'll real... Robert Mustacchi

2020-05-10

10:32 PM illumos gate Bug #12720 (Closed): _fini(9E) could note it's not called when _init fails
A question came up of whether or not _fini(9E) will be called when _init(9E) fails in a driver. This is quite importa... Robert Mustacchi
10:29 PM illumos gate Bug #12719 (Closed): ioctl(9E) should mention what to return for an unknown command
Currently ioctl(9E) doesn't really talk about what drivers should do if they don't recognize a command. The time hono... Robert Mustacchi

2020-05-09

11:20 PM illumos gate Bug #12686: dladm: vnic creation over bge0 failed: object already exists
I've put together a potential prototype at https://code.illumos.org/c/illumos-gate/+/653. If folks would be able to t... Robert Mustacchi
09:22 PM illumos gate Bug #12686: dladm: vnic creation over bge0 failed: object already exists
Thanks for providing this everyone. With this, I think I understand everything that's happening here. Let me recap a ... Robert Mustacchi

2020-05-05

01:51 AM illumos gate Bug #12686: dladm: vnic creation over bge0 failed: object already exists
Thanks for that Chris. That helps point us in the right direction. What's happening is that we're failing this bit of... Robert Mustacchi

2020-05-04

07:32 PM illumos gate Feature #12691 (Closed): Want means of getting the maximum user address in a process
The CoreCLR part of .net, and presumably other software, wants to know what the maximum mapable user address is. For ... Robert Mustacchi
02:06 AM illumos gate Feature #12689 (New): Want c11 uchar.h
The C11 standard introduced the @uchar.h@ header and associated library routines:
* mbrtoc16
* c16rtomb
* mbrtoc...
Robert Mustacchi

2020-05-01

10:57 PM illumos gate Feature #12685 (Closed): ddi_create_minor_node() should take const char * values
The implementation of ddi_create_minor_node(9F) duplicates the node name that is passed to it and generally reference... Robert Mustacchi

2020-04-29

10:13 PM illumos gate Bug #12664 (Closed): fix smbios memory technology operating mode capabilities
While looking at a system with a DIMM, I noticed a few peculiarities:... Robert Mustacchi
10:05 PM illumos gate Bug #12662 (Closed): smbios(1M) interprets jedec IDs incorrectly
While on a system with SMBIOS 3.2 support, I noticed that we actually had a Jedec ID for the memory module in smbios(... Robert Mustacchi

2020-04-28

10:40 PM illumos gate Bug #12637 (New): ses_facility.c topo methods are not properly terminated
When a series of FMA topo methods are registered, the resulting array must be null terminated. After auditing the sou... Robert Mustacchi

2020-04-24

08:47 PM illumos gate Bug #12594: bge device IDs do not have a leading 0x
Tested this mostly through the build. Robert Mustacchi
01:17 AM illumos gate Bug #12594 (Closed): bge device IDs do not have a leading 0x
When adding some PCI IDs for 12450 I erroneously added a leading 0x due to some copy and pasting from the headers for... Robert Mustacchi
 

Also available in: Atom