Project

General

Profile

Patrick Mooney's activity

From 2020-05-02 to 2020-05-31

2020-05-29

10:40 PM illumos gate Feature #12775: reorganize bhyve contrib headers
Considering this was just file reorganization, I tested only by @wsdiff(1)@-ing a build with the change against a "va... Patrick Mooney

2020-05-26

11:44 PM illumos gate Feature #12792 (Closed): bhyve upstream sync 2020 May
Sync upstream activity in FreeBSD's bhyve into illumos.
For now, we'll be ignoring the changes made to support save/...
Patrick Mooney

2020-05-25

04:21 PM illumos gate Bug #12766: clean up bhyve lints
A @wsdiff@ run between this wad and the vanilla gate noted no meaningful differences. Patrick Mooney
03:48 PM illumos gate Feature #12736: Add DISCARD/TRIM support to bhyve
The proposed wad is a combination of "bfe191c4":https://github.com/joyent/illumos-joyent/commit/bfe191c490dc33e77e134... Patrick Mooney

2020-05-23

11:44 PM illumos gate Bug #12766 (Pending RTI): clean up bhyve lints
Patrick Mooney
06:58 PM illumos gate Bug #12766: clean up bhyve lints
Considering lint is deprecated, this should have no effect on the build or the emitted artifacts. I ran a full clean... Patrick Mooney
11:42 PM illumos gate Feature #12775 (In Progress): reorganize bhyve contrib headers
Patrick Mooney
05:28 PM illumos gate Feature #12736: Add DISCARD/TRIM support to bhyve
I smoke-tested this using an illumos-gate build atop an OmniOSce machine. The guest I was using (CentOS7) was runnin... Patrick Mooney

2020-05-22

09:11 PM illumos gate Feature #12735: bhyve upstream sync 2019 Sept
After the testing done in SmartOS, I built this on top of illumos-gate and smoke-tested a VM on my OmniOSce hardware ... Patrick Mooney
04:05 PM illumos gate Feature #12682: want mdb-bhyve module
And additional note on testing: After merging this into SmartOS, no regressions were noted in unrelated mdb operation... Patrick Mooney
04:03 PM illumos gate Feature #12682: want mdb-bhyve module
This change has been in SmartOS and OmniOS for over a year now. When initially merged into SmartOS, Hans mentioned h... Patrick Mooney
02:09 AM illumos gate Bug #12777 (Closed): libc unwinding confused by indirect pointer encoding
Joshua Clulow reported that a rust binary (the accounts test suite for olm-rs) was segfaulting in a manner that sugge... Patrick Mooney

2020-05-21

07:54 PM illumos gate Feature #12775 (Closed): reorganize bhyve contrib headers
When bhyve was initially merged, its 'contrib' headers landed in @usr/contrib@ thanks to the original Pluribus lineag... Patrick Mooney
05:00 PM illumos gate Feature #12737 (In Progress): sync shadow PCIR_COMMAND with real one for bhyve pass-thru
Patrick Mooney
04:59 PM illumos gate Feature #12736 (In Progress): Add DISCARD/TRIM support to bhyve
Patrick Mooney
04:59 PM illumos gate Feature #12735 (In Progress): bhyve upstream sync 2019 Sept
Patrick Mooney

2020-05-20

06:46 PM illumos gate Feature #12680: want PCI pass-thru in bhyve
Hans built this patchset to test on OI. With it loaded, he was able to pass-thru a wireless device into a Linux gues... Patrick Mooney
12:40 PM illumos gate Bug #12766 (Closed): clean up bhyve lints
While upstreaming bhyve and its related components, since-obsoleted lint infrastructure was left in place. This was ... Patrick Mooney
01:19 AM illumos gate Bug #12746: x86_emulate_cpuid() should clear upper 32 bits
Using the above script, bhyve would behave as noted in the issue report, leaving any garbage in the upper bits untouc... Patrick Mooney
12:30 AM illumos gate Bug #12746: x86_emulate_cpuid() should clear upper 32 bits
Here's a silly little test program I've used to check if high bits in a CPUID operation are cleared:... Patrick Mooney

2020-05-19

09:49 PM illumos gate Feature #12680: want PCI pass-thru in bhyve
I've compared the downstream (SmartOS) sources with this proposed patch, and we match for all of the PPT and bhyve re... Patrick Mooney

2020-05-18

10:14 PM illumos gate Bug #12738: Panic in vlapic_callout_handler
As noted in the SmartOS ticket, reproducing this issue proved difficult. Only one of their customers reported seeing... Patrick Mooney
09:48 PM illumos gate Feature #12679: want viona driver for bhyve
These viona patches were compared against their downstream SmartOS counterparts. Furthermore they were smoke-tested ... Patrick Mooney
09:45 PM illumos gate Feature #12679: want viona driver for bhyve
It should be noted that while the Reviewed-by list for the upstreaming commit is limited, nearly all of the included ... Patrick Mooney
09:44 PM illumos gate Feature #12679: want viona driver for bhyve
This driver, along with its associated changes, has been in production in Joyent SmartOS for an extended period of ti... Patrick Mooney
06:15 PM illumos gate Bug #12749 (Closed): gcc10 complains about vmcb_state struct packing
As noted in #12746, gcc10 was complaining about pointer access into the @vmcb_state@ struct:... Patrick Mooney
02:05 AM illumos gate Bug #12746 (Closed): x86_emulate_cpuid() should clear upper 32 bits
When investigating a gcc9 gripe in the bhyve codebase, I noticed something that looked amiss:... Patrick Mooney

2020-05-15

07:24 PM illumos gate Feature #12676: want better offloads for vnics
These changes have been in SmartOS for a while. OmniOSce has also side-pulled them for bhyve. Patrick Mooney
05:07 PM illumos gate Feature #12676: want better offloads for vnics
Test results from rpz:... Patrick Mooney

2020-05-14

11:52 PM illumos gate Feature #12734 (Closed): bhyve on AMD should report SVM as disabled
Patrick Mooney
11:52 PM illumos gate Feature #12734: bhyve on AMD should report SVM as disabled
This was missed in the commit list for #12665 and has already been imported there. Patrick Mooney
11:04 PM illumos gate Feature #12734 (Closed): bhyve on AMD should report SVM as disabled
Upstreaming "OS-8008":https://smartos.org/bugview/OS-8008 from SmartOS:
As reported in https://github.com/joyent/s...
Patrick Mooney
11:18 PM illumos gate Bug #12738 (Closed): Panic in vlapic_callout_handler
Upstreaming "OS-8076":https://smartos.org/bugview/OS-8076 from SmartOS:
Customer reported a panic:...
Patrick Mooney
11:12 PM illumos gate Feature #12737 (Closed): sync shadow PCIR_COMMAND with real one for bhyve pass-thru
Upstreaming "OS-8143":https://smartos.org/bugview/OS-8143 from SmartOS:
This is a follow up to "OS-8117":https://s...
Patrick Mooney
11:08 PM illumos gate Feature #12736 (Closed): Add DISCARD/TRIM support to bhyve
Upstreaming "OS-8136":https://smartos.org/bugview/OS-8136 from SmartOS:
It uses the existing blockif delete functi...
Patrick Mooney
11:06 PM illumos gate Feature #12735 (Closed): bhyve upstream sync 2019 Sept
Upstreaming "OS-8117":https://smartos.org/bugview/OS-8117 from SmartOS:
This merge contains mostly userspace chang...
Patrick Mooney
08:21 PM illumos gate Feature #12665: want modern bhyve
On top of all the testing that was done in SmartOS (and later OmniOSce), I smoke tested this along with the viona bit... Patrick Mooney
02:42 PM illumos gate Bug #12731: disable IPv6 LSO until emulation is available
Ryan built this on top of #12676 (which spurred the need for it) to test and observed TSOv6 as properly disabled on c... Patrick Mooney

2020-05-13

09:07 PM illumos gate Bug #12731 (Closed): disable IPv6 LSO until emulation is available
Prior to the integration of #12676, we should disable advertisement of IPv6 TSO/LSO. This is because no emulation is... Patrick Mooney
07:45 PM illumos gate Feature #12730 (New): document kthread worker interface
In #12675, the ability to create kernel-only worker threads in a process was added. It would be valuable to add deta... Patrick Mooney
07:42 PM illumos gate Feature #12675: want kthread worker interface
On a system with this patch (and the subsequent bhyve patches so that a consumer, viona, would be present) I tried so... Patrick Mooney
03:34 PM illumos gate Feature #12675: want kthread worker interface
This has been in use by viona for bhyve (and LX) on SmartOS and OmniOSce for over a year now. Patrick Mooney

2020-05-11

08:54 PM illumos gate Feature #12674: want mac rx barrier function
This was tested first on SmartOS bhyve. After integration there, it was side-pulled by OmniOSce. Patrick Mooney
08:26 PM illumos gate Feature #12714: want privilege for hypervisors
I don't have strong opinions one way or the other. I'll be happy with whatever we can collectively settle on. My bi... Patrick Mooney
08:09 PM illumos gate Feature #12714: want privilege for hypervisors
John Levon wrote:
> Did you consider re-using the golden oldie PRIV_VIRT_MANAGE?
I had not. Seeing it now, I hav...
Patrick Mooney

2020-05-10

04:39 PM illumos gate Bug #12718 (Closed): LDT overlap with TSS reintroduced in 12608
Andy F spotted an issue with the #12608 wad: It adjusts the layout of the TSS and LDT on cpu0 back to its previously ... Patrick Mooney

2020-05-09

11:18 PM illumos gate Feature #12714 (New): want privilege for hypervisors
The inclusion of bhyve in illumos exacerbates our current lack of a privilege for controlling access to HVM-related t... Patrick Mooney
04:46 PM illumos gate Feature #12672: want mac_hcksum_clone function
This underwent testing and use as part of the MAC enhancements (including #12676) implemented for the bhyve viona dri... Patrick Mooney
04:28 PM illumos gate Feature #12671: hcksum routines are too verbose
I do not have access to environments with the NICs which had their drivers modified by this change. I'm relying on t... Patrick Mooney

2020-05-08

11:35 PM illumos gate Feature #12554: want sdev plugin framework
With bhyve slated as the first consumer of the plugin interface, this wad was primarily tested for regressions (altho... Patrick Mooney

2020-05-04

09:35 PM illumos gate Feature #12673 (Closed): promisc DLS needs fixups
Patrick Mooney
09:35 PM illumos gate Feature #12673: promisc DLS needs fixups
Further investigation of how this fits into MAC and the rest of the viona upstreaming bits has show that it should no... Patrick Mooney

2020-05-03

07:12 PM illumos gate Feature #12673: promisc DLS needs fixups
To merge this properly, some bits needed to be pulled up from the Bardiche (OS-2800) wad, in addition to a fix-up fro... Patrick Mooney
06:35 PM illumos gate Feature #12675: want kthread worker interface
The portion of this required for bhyve/viona upstreaming is only the @TP_KTHREAD@ addition (and its consuming logic i... Patrick Mooney
05:44 PM illumos gate Feature #12674: want mac rx barrier function
A small change needed, since this is being integrated before the vnic-LSO/loopback wad:... Patrick Mooney
 

Also available in: Atom