Project

General

Profile

Robert Mustacchi's activity

From 2020-10-26 to 2020-11-24

2020-11-24

04:02 PM illumos gate Bug #10525: wsdiff output is not correct for a binary file
The underlying cause of the differences in hlista and hlistb are in #13333. Robert Mustacchi
03:53 PM illumos gate Bug #13333 (Closed): spellcheck1 doesn't zero table memory
Having mostly ignored the wsdiff noise that ocasionally pops up between hlista and hlistb, I decided to reverse cours... Robert Mustacchi

2020-11-22

07:15 PM illumos gate Bug #13319: Typos in some LDSTACKPROTECT macros
To test this, I ran a wsdiff and verified that there was nothing surprising there (e.g. acpi and hlist). Robert Mustacchi

2020-11-19

01:36 AM illumos gate Bug #13319 (Closed): Typos in some LDSTACKPROTECT macros
With the work in #13274 to enable the tack protector in the build, an effort was made to mimic the conditions that we... Robert Mustacchi

2020-11-18

02:05 AM illumos gate Bug #13312: _thrp_create() should not set the thread name if passed an empty string
I did two things here. First I ran the libc tests to verify that this all passed:... Robert Mustacchi

2020-11-15

04:25 PM illumos gate Feature #13273: want upanic(2)
I tested this in the following ways:
* I wrote small programs that called upanic and verified the following differen...
Robert Mustacchi
04:21 PM illumos gate Feature #5788: Want support for GCC's stack protector in libc
To test the stack protector we did a few things:
* We wrote small test programs that would trigger it on different...
Robert Mustacchi
04:18 PM illumos gate Feature #13274: enable -fstack-protector-strong by default in user land
To test this I did the following:
* Manually verified that we had emitted calls to the stack protector into most b...
Robert Mustacchi

2020-11-13

08:05 PM illumos gate Feature #13306: Need support for BCM57416
It is the same driver as mentioned in #12772. Let me update the title of that so that it makes more sense. Robert Mustacchi

2020-11-10

01:36 AM illumos gate Bug #13247: CTF conversion fails with large files
It certainly wasn't the intent of the CTF everywhere changes to regress the output on error messages, so if there's s... Robert Mustacchi
01:32 AM illumos gate Bug #13281: bump crypto tests timeout
I tested this by making sure that the crypto tests now all pass successfully and do not time out. Robert Mustacchi
01:00 AM illumos gate Bug #13300 (Closed): mlxcx_cq_setup() doesn't take required locks for ASSERTs
On debug, a user saw a panic occur in @mlxcx_arm_cq()@ because they didn't have the @mlcq_arm_mtx@ lock held. This on... Robert Mustacchi

2020-11-04

03:06 PM illumos gate Bug #13281 (Closed): bump crypto tests timeout
Today, the pkcs11 crypto tests are written in such a way that they honor pkcs11.conf, which is a bit unfortunate as i... Robert Mustacchi

2020-11-03

08:46 PM illumos gate Bug #13271: 64-bit crypto tests have wrong library search path
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:46 PM illumos gate Bug #13270: cmd/spell native build incomplete
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:46 PM illumos gate Bug #13265: libmp.so.1 missing library search path
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13268: lp native build forgot CFLAGS
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13266: mdb build tools should use native tools
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13261: libdbus-1 deps missing libbsm
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13263: startd needs to search $(ROOT)/usr/lib/fm for deps
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13264: perl Makefiles place object files after libraries
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:45 PM illumos gate Bug #13260: librtld_db demo should be built separately
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:44 PM illumos gate Bug #13272: 64-bit secflags test has wrong ldlibs
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi
08:44 PM illumos gate Bug #13269: esc needs a native build
I tested this primarily through wsdiff and verified that there were no changes induced by this. I also verified the b... Robert Mustacchi

2020-10-31

03:55 PM illumos gate Feature #5788: Want support for GCC's stack protector in libc
To support the stack protector there are a few things we need:
1. libc needs the @__stack_chk_fail@ function
2. l...
Robert Mustacchi
03:55 PM illumos gate Feature #13274 (Closed): enable -fstack-protector-strong by default in user land
It is long past time for @-fstack-protector-strong@ to be enabled by default in user land in the build. This goes thr... Robert Mustacchi
03:38 PM illumos gate Feature #13273 (Closed): want upanic(2)
When terminating a process due to an erroneous condition, the common trend is to use abort(). This has a number of ch... Robert Mustacchi
03:27 PM illumos gate Bug #13272 (Closed): 64-bit secflags test has wrong ldlibs
The 64-bit secflags tests end up referring to the 32-bit library path rather than the 64-bit library path making it h... Robert Mustacchi
03:26 PM illumos gate Bug #13271 (Closed): 64-bit crypto tests have wrong library search path
The 64-bit crypto tests have the wrong library search path. Right now they end up specifying the 32-bit path, not the... Robert Mustacchi
03:25 PM illumos gate Bug #13270 (Closed): cmd/spell native build incomplete
The cmd/spell build has a native program and while it make sure to set up @CC@ and @CPPFLAGS@ for the native build, i... Robert Mustacchi
03:23 PM illumos gate Bug #13269 (Closed): esc needs a native build
The eversholt compiler (esc) is used as part of the fault management architecture. It is both built and installed to ... Robert Mustacchi
03:20 PM illumos gate Bug #13268 (Closed): lp native build forgot CFLAGS
cmd/lp has a native build where a few different utilities are built. While most of the native flags are correctly set... Robert Mustacchi
03:18 PM illumos gate Bug #13267 (Closed): tools libld build picks up normal sgs libs
We build an ld to run on the build host to make it easier to use new features in the build. To do this, we try to reu... Robert Mustacchi
03:14 PM illumos gate Bug #13266 (Closed): mdb build tools should use native tools
mdb has a few tools that it uses to try and get access to information, @findfp@ and @setdynflag@ that are meant to be... Robert Mustacchi
03:10 PM illumos gate Bug #13265 (Closed): libmp.so.1 missing library search path
libmp.so.1 is a special compatibility build of libmp.so.2. Because of how it's manually specified in the Makefiles, i... Robert Mustacchi
03:08 PM illumos gate Bug #13264 (Closed): perl Makefiles place object files after libraries
The perl Makefiles in usr/src/cmd/perl are constructed such that all library dependencies are placed *before* the act... Robert Mustacchi
03:07 PM illumos gate Bug #13263 (Closed): startd needs to search $(ROOT)/usr/lib/fm for deps
startd currently links against @libfmevent.so@ which is found in @/lib/fm@. This library has a dependency itself on @... Robert Mustacchi
03:04 PM illumos gate Bug #13262 (Closed): rcm_daemon missing library search paths
The rcm_daemon builds several shared objects and manually specifies their search path as @-L$(ROOT)/lib@. This is all... Robert Mustacchi
03:02 PM illumos gate Bug #13261 (Closed): libdbus-1 deps missing libbsm
Today, libdsus-1 is expected to come from the build machine. To account for the fact that we want to make sure we gen... Robert Mustacchi
02:59 PM illumos gate Bug #13260 (Closed): librtld_db demo should be built separately
The librtld_db directory contains a separate demo application that shows how one might use librtld_db. The way this i... Robert Mustacchi

2020-10-26

06:57 PM illumos gate Feature #13238: vaes, vpclmulqdq should be plumbed through isainfo
I tested this by doing a few things:
* Verifying that values showed up in @::x86_featureset@
* Verifying that the...
Robert Mustacchi
06:56 PM illumos gate Feature #13239: umip, etc. are incorrectly conditioned in cpuid.c
I verified this by making sure that we still saw the expected features in @::x86_featureset@. Robert Mustacchi
06:53 PM illumos gate Feature #13237: Plumb through PCID on AMD
I verified that pcid was being detected in @::x86_featureset@ in mdb and verified that @x86_use_pcid@ is set to one. Robert Mustacchi
06:49 PM illumos gate Feature #13236: Want Zen 3 socket information
I tested this by verifying that I got the right socket detected on a proto system. Robert Mustacchi
06:47 PM illumos gate Feature #13235: amdzen(7D) support for Zen 3
I tested this by verifying that the smntemp driver came up and had temperature information, as well as that the other... Robert Mustacchi
 

Also available in: Atom