Project

General

Profile

Andy Fiddaman's activity

From 2021-03-08 to 2021-04-06

2021-04-06

06:58 PM illumos gate Feature #13698 (In Progress): CTF could handle C99 VLAs in function arguments
Andy Fiddaman
01:05 PM illumos gate Feature #13698 (In Progress): CTF could handle C99 VLAs in function arguments
@ctfconvert@ cannot convert data for function definitions which contain some types of C99 variable length array (VLA)... Andy Fiddaman

2021-04-05

10:57 PM illumos gate Bug #13695: Can't create VNICs over vioif after 13637
I tested this change by booting the OmniOS VM shown in the issue description on a patched system. I was again able to... Andy Fiddaman
08:18 PM illumos gate Bug #13695 (Closed): Can't create VNICs over vioif after 13637

Up until #13637 was integrated, vioif interfaces ignored requests to enable promiscuous mode, but returned success....
Andy Fiddaman
10:50 PM illumos gate Bug #13694: regex has problems with simple ranges in UTF-8 locales
I have found references that say that POSIX 1992 defined the ordering for a range expression (outside of the C and PO... Andy Fiddaman
12:34 PM illumos gate Bug #13694 (New): regex has problems with simple ranges in UTF-8 locales
In UTF-8 locales, other than @c.UTF-8@, the libc regex has problems with simple ranges such as @[A-Z]@, including at ... Andy Fiddaman
09:35 PM illumos gate Bug #13201: IPS image re-hydration fails
Dehydrating an IPS image removes all non-editable packaged files and hardlinks from the image, leaving behind the dir... Andy Fiddaman
08:49 AM illumos gate Bug #13201: IPS image re-hydration fails
With the referenced change, rehydration succeeds:... Andy Fiddaman

2021-04-02

06:38 PM illumos gate Bug #13692 (Closed): bhyve panic if vmm_drv_purge() fails
An OmniOS user reported a crash while testing the bits from #13674 .
By mistake, the user ran a shell script which l...
Andy Fiddaman
04:07 PM illumos gate Bug #13601: ksh shell lint misleading
With the change in the associated Gerrit review, this changes from:... Andy Fiddaman
03:04 PM illumos gate Bug #13601 (In Progress): ksh shell lint misleading
Andy Fiddaman
04:05 PM illumos gate Bug #13631: shell lint about variable expansion in arithmetic expressions is inscrutable
With the change in the associated Gerrit review, this changes from:... Andy Fiddaman
03:04 PM illumos gate Bug #13631 (In Progress): shell lint about variable expansion in arithmetic expressions is inscrutable
Andy Fiddaman

2021-03-28

09:37 PM illumos gate Bug #7668 (In Progress): zfs get only outputs 3 columns if "clones" property is empty
Andy Fiddaman

2021-03-27

08:37 PM illumos gate Feature #13678 (In Progress): Make zpool list -vp print individual vdev sizes parsable.
Andy Fiddaman

2021-03-26

01:28 PM illumos gate Feature #13674 (In Progress): bhyve upstream sync 2021 March
Sync upstream activity in FreeBSD's bhyve into illumos. Andy Fiddaman

2021-03-25

04:28 PM illumos gate Bug #13661: printf builtin should ignore leading --
Tested using the @builtin@ test program before and after the change, which showed failures before and none after.
Re...
Andy Fiddaman
03:29 PM illumos gate Feature #13670 (Closed): OmniOS openssl package renames
In OmniOS r151038 and beyond, the @openssl@ packages have been renamed to be more consistent:
* openssl-10
* openss...
Andy Fiddaman
03:16 PM illumos gate Feature #2755: split ksh93 from core package
This is also now integrated into OmniOS and I've done several updates (onu and otherwise) from the old package layout... Andy Fiddaman

2021-03-23

01:35 PM illumos gate Bug #13625: rename SUNWcs and SUNWcsd
and as part of this, or as a followup, can we also please separate out the @reboot-required@ bits?
It's unfortunate ...
Andy Fiddaman

2021-03-22

03:28 PM illumos gate Bug #13661 (Closed): printf builtin should ignore leading --
Even though printf does not support option flags, POSIX requires that it ignores any leading @--@, and it currently d... Andy Fiddaman

2021-03-20

02:33 PM illumos gate Bug #13658 (Closed): exception_lists/cstyle has stale entries
and at least one typo.. Andy Fiddaman

2021-03-19

09:01 PM illumos gate Bug #13635: libast does not link with gcc4
Tested by running a gate build with gcc7 primary and comparing workspaces with wsdiff.
I also did a gate build with ...
Andy Fiddaman
04:26 PM illumos gate Feature #2755: split ksh93 from core package
Tested by doing a full build and a wsdiff between that and the previous commit. The only differences were the moved t... Andy Fiddaman

2021-03-18

02:23 PM illumos gate Bug #13648 (Closed): chroot(1m) man page references libcmd.so instead of libcmdutils.so
it's also missing a few other required libraries from the example. Andy Fiddaman
11:58 AM illumos gate Feature #13642: onu could support updating on OmniOS
I tested this change in conjunction with #13646 and #13647
@onu@ is now successful on both OmniOS and OpenIndiana ...
Andy Fiddaman
11:34 AM illumos gate Bug #13647 (In Progress): onu does not work with python3.x
... Andy Fiddaman
11:16 AM illumos gate Bug #13646 (In Progress): onu fails if the system being updated has linked image zones
This occurs because the @onu@ script does not update the publishers in the linked zones, causing a linked image excep... Andy Fiddaman

2021-03-16

11:05 PM illumos gate Feature #13642 (In Progress): onu could support updating on OmniOS
When using @onu@ to create an illumos-gate boot environment on a running OmniOS system, there is an extra required st... Andy Fiddaman
10:43 PM illumos gate Feature #13641 (New): svccfg(1M) should document setnotify/listnotify/delnotify
The svccfg(1M) man page does not document these subcommands. Andy Fiddaman
10:39 PM illumos gate Bug #13640 (In Progress): brand uninstall scripts need ksh fixes
@usr/src/lib/brand/solaris10/zone/uninstall.ksh@ and @usr/src/lib/brand/shared/zone/uninstall.ksh@ use ksh patterns o... Andy Fiddaman
07:24 PM illumos gate Feature #4933 (Duplicate): getcwd(3c) could be more useful
Closing this one now as #13586 has integrated.
(I should have added both issues to the change or closed the newer on...
Andy Fiddaman
05:27 PM illumos gate Bug #4149: ksh head builtin does not like newlines
The fix that I've put for review basically amounts to a backport of the fix from ksh93 2013:
> 13-09-19 head.c,tai...
Andy Fiddaman

2021-03-15

10:54 AM illumos gate Bug #13635 (Closed): libast does not link with gcc4
If gate is built using gcc4 as the primary compiler, libast does not link.... Andy Fiddaman

2021-03-14

01:33 PM illumos gate Bug #12558: Builtin command "printf" of ksh93 does not behave as specified
Jens Elkner wrote in #note-8:
> And fixing the test is not an option?
Definitely, but not part of this change.
I...
Andy Fiddaman

2021-03-13

07:33 PM illumos gate Bug #13631: shell lint about variable expansion in arithmetic expressions is inscrutable
I wonder if we can just pad out the lint output to be more informative, or whether to be more selective about what wa... Andy Fiddaman
02:06 PM illumos gate Bug #12558: Builtin command "printf" of ksh93 does not behave as specified
The note about the test failure was just for the person who has to approve this change - the test failure is easily e... Andy Fiddaman

2021-03-12

09:16 PM illumos gate Bug #13627 (Closed): chown(2) mixes up chown() and fchown()
the first paragraph describes fchown() ["or referenced by the open file descriptor fildes"] but fails to name it, lea... Andy Fiddaman
09:12 PM illumos gate Bug #3782: ksh93's builtin chown fails with numeric ids
I tested this fix by using the builtin chown to repeatedly apply a number UID, GID and combination of the two.
Witho...
Andy Fiddaman

2021-03-10

03:36 PM illumos gate Bug #4149 (In Progress): ksh head builtin does not like newlines
The builtin tail command code is using libast's @sfmove()@ function to copy input to stdout, and this function is des... Andy Fiddaman

2021-03-09

08:32 PM illumos gate Bug #9620: getcwd() syscall has unbounded memory allocation
and with a user supplied buffer that is too small:... Andy Fiddaman
11:36 AM illumos gate Bug #9620: getcwd() syscall has unbounded memory allocation
Some more testing notes:
With a path that is bigger than @kmem_max_cached@.
This is in conjunction with #13586, l...
Andy Fiddaman
12:30 PM illumos gate Bug #3781 (Closed): ksh93's builtin ln inconsistent
I can't replicate this with the 2020 gate ksh (@Version JM 93t+ 2010-03-05@) or the current one (@Version jM 93u+ 201... Andy Fiddaman
11:23 AM illumos gate Feature #13586: getcwd() should accept a 0 length argument
Some more testing notes:
For a fairly standard short path:...
Andy Fiddaman

2021-03-08

09:57 PM illumos gate Feature #13586: getcwd() should accept a 0 length argument
I tested this in conjunction with the fix for #9620 because otherwise I hit that bug when using very long paths.
W...
Andy Fiddaman
08:40 PM illumos gate Bug #3782: ksh93's builtin chown fails with numeric ids
This is being caused by libast's @struid()@ (@strgid()@) functions which convert a name to a uid (gid).
When a name ...
Andy Fiddaman
05:38 PM illumos gate Bug #3782 (In Progress): ksh93's builtin chown fails with numeric ids
Andy Fiddaman
04:46 PM illumos gate Bug #3779 (Resolved): ksh93's builtin chown handling is busted
I cannot reproduce this with the current ksh93 in gate, and nor could it be reproduced 8 years ago with the upstream ... Andy Fiddaman
03:59 PM illumos gate Feature #13612 (Closed): Convert ksh93.1 to mdoc
Andy Fiddaman
02:38 PM illumos gate Bug #12558: Builtin command "printf" of ksh93 does not behave as specified
I've tested the proposed change by running a variety of parameters through both the ksh93 builtin and /usr/bin/printf... Andy Fiddaman
02:35 PM illumos gate Bug #12558 (In Progress): Builtin command "printf" of ksh93 does not behave as specified
This is indeed because of shared code between @print@ and @printf@.
Although the @printf@ command is correctly decla...
Andy Fiddaman
01:08 PM illumos gate Bug #12302: ksh dumps core while parsing functions

Testing...
Andy Fiddaman
01:01 PM illumos gate Bug #12302: ksh dumps core while parsing functions
This is happening because the @savstak@ variable in sh/parse.c:@funct()@ is not initialised.
For functions which cont...
Andy Fiddaman
12:58 PM illumos gate Bug #12302 (In Progress): ksh dumps core while parsing functions
Andy Fiddaman
12:08 PM illumos gate Bug #12302: ksh dumps core while parsing functions
With the latest illumos @ksh93@, I can only replicate this with the 32-bit version.... Andy Fiddaman
 

Also available in: Atom