Project

General

Profile

Bug #10014

bootadm: menu_free() is accessing freed memory

Added by Toomas Soome 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-11-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Issue pointed by John Levon. We can not use STAILQ_FOREACH for freeing the list.

History

#1

Updated by Joshua M. Clulow 8 months ago

Toomas tested this by running bootadm list-menu.

#2

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 135ec7c89feffe489942d5c5a37e69f4efb7d7bb

commit  135ec7c89feffe489942d5c5a37e69f4efb7d7bb
Author: Toomas Soome <tsoome@me.com>
Date:   2018-12-03T21:52:29.000Z

    10014 bootadm: menu_free() is accessing freed memory
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.net>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Also available in: Atom PDF