Project

General

Profile

Actions
Copy link

Bug #10017

closed

libilb: macro expands to multiple statements

Added by Toomas Soome almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-11-30
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Issue found by gcc 8 build:

    ../common/ilb_sg.c: In function 'i_ilb_fillin_srvdata':
    ../common/libilb_impl.h:79:2: error: macro expands to multiple statements [-Werror=multistatement-macros]
      bzero(_i, sizeof (*(_i)));    \
      ^~~~~
    ../common/ilb_sg.c:430:3: note: in expansion of macro 'IP_COPY_CLI_2_IMPL'
       IP_COPY_CLI_2_IMPL(&srv->sd_addr, &sgs->sgs_addr);
       ^~~~~~~~~~~~~~~~~~
    ../common/ilb_sg.c:429:2: note: some parts of macro expansion are not guarded by this 'else' clause
      else
      ^~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit fa79a855d371dfcb29461ad6ebaf48a458bf9f14

commit  fa79a855d371dfcb29461ad6ebaf48a458bf9f14
Author: Toomas Soome <tsoome@me.com>
Date:   2018-12-05T01:59:03.000Z

    10017 libilb: macro expands to multiple statements
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF