Project

General

Profile

Bug #10089

phy_check() is bitwise, should be streetwise

Added by John Levon almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
2018-12-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

mii.c was using a bitwise operation when it should be logical. By change, it happened to work the same.

History

#1

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 945e3b4bc345679cad92f0a896670030a411c8f8

commit  945e3b4bc345679cad92f0a896670030a411c8f8
Author: John Levon <john.levon@joyent.com>
Date:   2019-03-16T11:49:13.000Z

    10089 phy_check() is bitwise, should be streetwise
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF