Project

General

Profile

Bug #10127

coreadm is mis-using strcpy()

Added by John Levon 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
2018-12-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

Replace the potential overflows with use of strlcpy()

History

#1

Updated by John Levon 9 months ago

I tested this by dumping very long values into an /etc/coreadm.conf, running coreadm -U, and verifying that it fails cleanly.

#2

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 588340b578485109e57c57bc12e5ea214d5c627b

commit  588340b578485109e57c57bc12e5ea214d5c627b
Author: John Levon <john.levon@joyent.com>
Date:   2019-01-23T21:59:20.000Z

    10127 coreadm is mis-using strcpy()
    Reviewed by: Sanjay Nadkarni <sanjay.nadkarni@nexenta.com>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF