Actions
Bug #10152
closedbge debugging always on
Start date:
2018-12-20
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
commit e9bd258d56101ab78fb969d00fe79c53ceb1aa47 Author: David Gwynne <david@gwynne.id.au> Date: Fri Jan 30 02:08:46 2015 +0000 3446 Update bge to support missing 57xx/577xx devices Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com> Approved by: Garrett D'Amore <garrett@damore.org>
introduced the following change:
-#define BGE_DEBUGGING 0 +#define BGE_DEBUGGING 1
which leads to performance problems due to the enabled debugging code.
Related issues
Updated by Marcel Telka about 4 years ago
- Related to Feature #3446: Update bge to support missing 57xx/577xx devices added
Updated by Carlos Neira about 4 years ago
Arne Jansen wrote:
[...]
introduced the following change:
[...]
which leads to performance problems due to the enabled debugging code.
I just checked the code and this is still hardcoding BGE_DEBUGGING to 1,
to test this I created a PR to illumos-omnios maybe some has a bge card just to test this change.
Updated by Marcel Telka over 3 years ago
- Status changed from New to In Progress
- Assignee set to Marcel Telka
Updated by Marcel Telka over 3 years ago
Updated by Marcel Telka over 3 years ago
- Status changed from In Progress to Pending RTI
Updated by Electric Monk over 3 years ago
- Status changed from Pending RTI to Closed
- % Done changed from 0 to 100
git commit 07de4b8b08600eb9a66746ea6cc4a9fbc7981e4f
commit 07de4b8b08600eb9a66746ea6cc4a9fbc7981e4f Author: Arne Jansen <arne@die-jansens.de> Date: 2019-12-13T17:25:35.000Z 10152 bge debugging always on Reviewed by: Marcel Telka <marcel@telka.sk> Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@joyent.com>
Actions