Project

General

Profile

Bug #10157

sgs/libld: cast between incompatible function types

Added by Toomas Soome 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-12-23
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Issue found by gcc8 build:

    ../common/support.c: In function 'ld64_sup_loadso':
    ../common/support.c:94:15: error: cast between incompatible function types from 'void (*)()' to 'uint_t (*)()' {aka 'unsigned int (*)()'} [-Werror=cast-function-type]
        version = ((uint_t(*)())fptr)(LD_SUP_VCURRENT);
                   ^
    cc1: all warnings being treated as errors

Use correct types so we would not need to cast.

History

#1

Updated by Electric Monk 10 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit c5749750a3e052f1194f65a303456224c51dea63

commit  c5749750a3e052f1194f65a303456224c51dea63
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-04T12:36:10.000Z

    10157 sgs/libld: cast between incompatible function types
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF