Project

General

Profile

Actions
Copy link

Bug #10162

closed

Sun/Solaris/Kstat: cast between incompatible function types

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
2018-12-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Issue found by gcc 8 build:

    Kstat.xs: In function 'XS_Sun__Solaris__Kstat_update':
    Kstat.xs:1386:29: error: cast between incompatible function types from 'int (*)(HV *, int)' {aka 'int (*)(struct hv *, int)'} to 'int (*)(HV *, void *)' {aka 'int (*)(struct hv *, void *)'} [-Werror=cast-function-type]
       if (! apply_to_ties(self, (ATTCb_t)read_kstats, (void *)TRUE)) {
                                 ^
    cc1: all warnings being treated as errors

Implement wrapper with proper arguments.

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9419bc2fc61b54b25a4e45211d31fcb920ff67cc

commit  9419bc2fc61b54b25a4e45211d31fcb920ff67cc
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-04T12:35:02.000Z

    10162 Sun/Solaris/Kstat: cast between incompatible function types
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Actions
Copy link

Also available in: Atom PDF