Bug #10189

fdbuffer: cast between incompatible function types

Added by Toomas Soome about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:2019-01-09
Priority:NormalDue date:
Assignee:Toomas Soome% Done:

100%

Category:driver - device drivers
Target version:-
Difficulty:Bite-size Tags:

Description

Issue found by gcc 8 build:

    ../../common/fs/fdbuffer.c: In function 'fdb_iosetup':
    ../../common/fs/fdbuffer.c:411:28: error: cast between incompatible function types from 'void (*)(buf_t *)' {aka 'void (*)(struct buf *)'} to 'int (*)()' [-Werror=cast-function-type]
          (b_flags & B_ASYNC) ? (int (*)())fdb_iodone : NULL,
                                ^
    cc1: all warnings being treated as errors

History

#1 Updated by Electric Monk about 1 month ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit b94c9724091d6587cd76f6ec562dc8888e3f31c0

commit  b94c9724091d6587cd76f6ec562dc8888e3f31c0
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-18T02:15:40.000Z

    10189 fdbuffer: cast between incompatible function types
    Reviewed by: Andy Fiddaman <af@citrus-it.net>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom