Project

General

Profile

Bug #10193

ddi_intr: cast between incompatible function types

Added by Toomas Soome 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2019-01-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 8 build:

    ../../common/os/ddi_intr.c: In function 'ddi_add_intr':
    ../../common/os/ddi_intr.c:1360:50: error: cast between incompatible function types from 'uint_t (*)(char *)' {aka 'unsigned int (*)(char *)'} to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
      if ((ret = ddi_intr_add_handler(hdl_p[inumber], (ddi_intr_handler_t *)
                                                      ^
    ../../common/os/ddi_intr.c: In function 'ddi_add_softintr':
    ../../common/os/ddi_intr.c:1495:6: error: cast between incompatible function types from 'uint_t (*)(char *)' {aka 'unsigned int (*)(char *)'} to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
          (ddi_intr_handler_t *)int_handler, int_handler_arg)) !=
          ^
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 8 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 71222654120258353fa867d14ad838c458c823d7

commit  71222654120258353fa867d14ad838c458c823d7
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-18T02:16:16.000Z

    10193 ddi_intr: cast between incompatible function types
    Reviewed by: Andy Fiddaman <af@citrus-it.net>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF