Project

General

Profile

Bug #10194

iscsi: this statement may fall through

Added by Toomas Soome 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-01-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Issue found by gcc 8 build:

    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2069:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (status_detail) {
       ^~~~~~
    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2075:2: note: here
      case 0x01:
      ^~~~
    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2076:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (status_detail) {
       ^~~~~~
    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2086:2: note: here
      case 0x02:
      ^~~~
    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2087:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (status_detail) {
       ^~~~~~
    ../../common/io/scsi/adapters/iscsi/iscsi_login.c:2125:2: note: here
      case 0x03:
      ^~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 9 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 7c9ce9e029489432cc8d45437d8ecd0b9750d68d

commit  7c9ce9e029489432cc8d45437d8ecd0b9750d68d
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-18T02:16:33.000Z

    10194 iscsi: this statement may fall through
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF