Bug #10205

Mounting zfs filesystems on startup shows incorrect data

Added by Alexander Pyhalov about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:2019-01-10
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:-
Difficulty:Medium Tags:needs-triage

Description

It seems we are incrementing sms->sm_done twice in share_mount_one_cb() -> report_mount_progress() in usr/src/cmd/zfs/zfs_main.c, so
a) header is never set (current == 2) initially
b) sometimes we see figures like (35/34).

History

#2 Updated by Alexander Pyhalov about 1 month ago

  • Description updated (diff)

#3 Updated by Alexander Pyhalov about 1 month ago

Tested change by copying zfs binary to /sbin/zfs.
With new zfs binary I see
correct "Mounting ZFS filesystems (x/y)" string on boot instead of "(null) (x/y)".

#4 Updated by Electric Monk about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 247b7da039fd88350c50e3d7fef15bdab6bef215

commit  247b7da039fd88350c50e3d7fef15bdab6bef215
Author: Alexander Pyhalov <apyhalov@gmail.com>
Date:   2019-01-11T06:14:24.000Z

    10205 Mounting zfs filesystems on startup shows incorrect data
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom