Project

General

Profile

Bug #10218

CONV_CAP_VAL_HW2_BUFSIZE wasn't updated

Added by Robert Mustacchi 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
2019-01-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

While working on other matters, I was noticed something odd in elfdump of the notes section. Look at the hwcap2 entry here:

...
          [17]  SUN_HWCAP2      0x3f
...

This made me ask, why wasn't this actually a valid value and size. Digging into this, what I eventually found, was that we were returning ELFCAP_ERR_BUFOVFL from the hwcap2 expansion routines. The reason for this is that the constant that libconv uses for sizing the buffer was not updated with the additional hardware capabilities that were added to the system. This should be expanded to better cover this.

History

#1

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed

git commit 161294fe5eab242f42189b33b59ebbe6ac9558f4

commit  161294fe5eab242f42189b33b59ebbe6ac9558f4
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-01-15T19:00:21.000Z

    10217 mdb: r9w isn't r8w
    10218 CONV_CAP_VAL_HW2_BUFSIZE wasn't updated
    10219 AV_386_2_AVX512VPOPCDQ elfcap name should be consistent
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF