Project

General

Profile

Bug #10243

topo_node_label_set() should take a const char* instead of char*

Added by Robert Mustacchi over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
lib - userland libraries
Start date:
2019-01-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

It's a minor issue, but it'd be preferable if topo_node_label_set() took a const char* as the type for the "label" param. This would allow us to clean up consumers that are forced to cast away the const when they call it.

History

#1

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed

git commit 672fc84a1840ce8ef60fc752e9ea374723d1135a

commit  672fc84a1840ce8ef60fc752e9ea374723d1135a
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-01-28T06:30:32.000Z

    10242 Project Tiresias: USB topology
    10243 topo_node_label_set() should take a const char* instead of char*
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF