Project

General

Profile

Bug #10244

svc.startd dgraph_state_transition_notify() gets IS_ENABLED() check wrong

Added by John Levon 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Start date:
2019-01-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage,smatch

Description

4713 } else if (stn_transition & stn_global &&
4714 (IS_ENABLED(v) 1 || to SCF_STATE_DISABLED)) {

/export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: graph.c:4714 dgraph_state_transition_notify() warn: masked condition '(v->gv_flags & (2 | 4)) == 1' is always false.

smatch is quite right. The impact seems fairly minimal in that we'll miss FM state transition events on enabling (I think).

If this is fixed, impossible_mask should be removed from svc/startd/Makefile

History

#1

Updated by John Levon 9 months ago

  • Tags changed from needs-triage to needs-triage,smatch

Also available in: Atom PDF