Project

General

Profile

Bug #10247

emlxs_vpi_logi_cmpl_action() gets topology change wrong

Added by John Levon 9 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2019-01-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage smatch

Description

13042                         /* Check for topology change (0=loop 1=fabric) */
13043                         old_topo = ((port->prev_did && 0xFFFF00) == 0)? 0:1;
13044                         new_topo = ((port->did && 0xFFFF00) == 0)? 0:1;
/export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/fibre-channel/fca/emlxs/emlxs_fcf.c:13043 emlxs_vpi_logi_cmpl_action() warn: should this be a bitwise op?
/export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/fibre-channel/fca/emlxs/emlxs_fcf.c:13044 emlxs_vpi_logi_cmpl_action() warn: should this be a bitwise op?

smatch has it right, I think. Impact unknown. Should fix up makefile if this gets resolved.

Also available in: Atom PDF