Project

General

Profile

Bug #10250

access_mask_check() has incorrect check

Added by John Levon over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2019-01-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage smatch
Gerrit CR:

Description

 877                 } else {
 878                         if ((acep->a_access_mask & mask_bit) &&
 879                             (acep->a_type & ACE_ACCESS_ALLOWED_ACE_TYPE)) {
 880                                 return (ENOTSUP);
 881                         }
 882                         return (0);
 883                 }

/export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../../common/acl/acl_common.c:879 access_mask_check() warn: bitwise AND condition is false here

ACE_ACCESS_ALLOWED_ACE_TYPE is 0, so this check can never succeed. Impact unknown.

Also available in: Atom PDF