Project

General

Profile

Bug #10251

ip_fanout gets IPsec check wrong

Added by John Levon 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2019-01-16
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage smatch

Description

2357         /*
2358          * Time for IPP once we've done reassembly and IPsec.
2359          * We skip this for loopback packets since we don't do IPQoS
2360          * on loopback.
2361          */
2362         if (IPP_ENABLED(IPP_LOCAL_IN, ipst) &&
2363             !(iraflags & IRAF_LOOPBACK) &&
2364             (protocol != IPPROTO_ESP || protocol != IPPROTO_AH)) {

/export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/inet/ip/ip_input.c:2363 ip_fanout_v4() warn: was && intended here instead of ||?

ip_fanout_v6() has the same issue.

History

#1

Updated by Dan McDonald 9 months ago

  • Subject changed from ip_fanout gets IPSec check wrong to ip_fanout gets IPsec check wrong

Also available in: Atom PDF