Project

General

Profile

Bug #10254

Build error for dtrace_isa.c on sparc

Added by Peter Tribble 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2019-01-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

Building on SPARC:

../../sparc/dtrace/dtrace_isa.c:945: error: conflicting types for 'dtrace_setreg'
../../common/sys/dtrace_impl.h:1265: note: previous declaration of 'dtrace_setreg' was here

In the intel version of the file, and the header, it's void(), while the sparc version incorrectly declares it to return int.

(And clearly, if it's void, it mustn't return a value.)

History

#1

Updated by Electric Monk 9 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit fec628e60aec45b40824841a8b7246141504d1cc

commit  fec628e60aec45b40824841a8b7246141504d1cc
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2019-01-20T23:46:34.000Z

    10254 Build error for dtrace_isa.c on sparc
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF