Project

General

Profile

Bug #10258

Not all the qinit changes were copied to sparc

Added by Peter Tribble 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2019-01-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

In 9903, the fields to qinit are now typed. Some sparc modules have close functions with the wrong type, leading to the following errors:

../../sun4/io/su_driver.c:220: error: initialization from incompatible pointer type
../../sun/io/zs_hdlc.c:179: error: initialization from incompatible pointer type
../../sun/io/zs_async.c:463: error: initialization from incompatible pointer type
../../../sun4u/montecarlo/io/scsb.c:135: error: initialization from incompatible pointer type
../../../sun4u/montecarlo/io/scsb.c:139: error: initialization from incompatible pointer type
../../../sun4u/starcat/io/dman.c:659: error: initialization from incompatible pointer type
../../../sun4u/starcat/io/dman.c:669: error: initialization from incompatible pointer type
../../../sun4u/starcat/io/dman.c:679: error: initialization from incompatible pointer type
../../../sun4u/starcat/io/dman.c:689: error: initialization from incompatible pointer type
../../sun4/io/su_driver.c:220: error: initialization from incompatible pointer type

The close functions in these modules need to be fixed to have the correct signature.

History

#1

Updated by Electric Monk 11 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 730a650a8706d6e53fbb34bcaa857f3db68b1000

commit  730a650a8706d6e53fbb34bcaa857f3db68b1000
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2019-01-20T23:46:47.000Z

    10258 Not all the qinit changes were copied to sparc
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Andy Fiddaman <af@citrus-it.net>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF