Project

General

Profile

Bug #10264

vgatext: NULL pointer errors

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-01-20
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

With NULL defined as (void *)0:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/conf.h:37,
                     from ../../intel/io/vgatext/vgatext.c:33:
    ../../intel/io/vgatext/vgatext.c: In function 'vgatext_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../intel/io/vgatext/vgatext.c:238:40: note: in expansion of macro 'NULL'
          INST2NODE1(unit), DDI_NT_DISPLAY, NULL);
                                            ^~~~
    In file included from ../../intel/io/vgatext/vgatext.c:41:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

#1

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8704b322140c9a4ebb9f5cef7c062773b3a8ead4

commit  8704b322140c9a4ebb9f5cef7c062773b3a8ead4
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-21T16:39:50.000Z

    10264 vgatext: NULL pointer errors
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF