Project

General

Profile

Actions
Copy link

Bug #10280

closed

ses enumerator module should make protocol/label prop mutable

Added by Rob Johnston almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rob Johnston
Category:
-
Start date:
2019-01-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Currently both the ses and disk topo enumerators sets the protocol/label property via the topo_node_label_set() interface, which defaults to making the label property immutable. The problem with this is that the labels set by the ses enumerator are based on strings read directly from firmware and sometimes these strings can be incorrect or not in a format we prefer. The normal way we'd workaround this would be to override the label via a platform-specific XML file. But because the property has been created with the TOPO_PROP_IMMUTABLE flag, we're not able to fix it up.

So this issue is to track changing the ses and disk enumerator such that it sets the protocol/label property to be mutable on any topo nodes it creates.

Actions
Copy link
 #1

Updated by Rob Johnston almost 3 years ago

Note that this change has already been integrated into illumos-joyent via the commits below:

commit c9422bbeaa6b10c8d0b398f4678ccdc8877757ab
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   Fri Jan 18 21:39:37 2019 +0000

    OS-7521 disk enumerator should make protocol/label prop mutable

commit 8ebfdc66bf6e05607c459ce7468ce7ec72f6f8c6
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   Mon Sep 10 21:40:22 2018 +0000

    OS-7180 ses enumerator should trim leading/trailing whitespace from labels
    OS-7234 ses enumerator should make protocol/label prop mutable
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Jordan Hendricks <jordan.hendricks@joyent.com>
Actions
Copy link
 #2

Updated by Rob Johnston almost 3 years ago

  • Subject changed from ses and disk enumerator modules should make protocol/label prop mutable to ses enumerator modules should make protocol/label prop mutable

For logistical reasons, I'm going to file a separate issue to track upstreaming OS-7521

Actions
Copy link
 #3

Updated by Rob Johnston almost 3 years ago

  • Difficulty changed from Medium to Bite-size
Actions
Copy link
 #4

Updated by Rob Johnston almost 3 years ago

Filed illumos#10321 to track the fixing the equivalent issue in the disk enumerator.

Actions
Copy link
 #5

Updated by Rob Johnston almost 3 years ago

  • Subject changed from ses enumerator modules should make protocol/label prop mutable to ses enumerator module should make protocol/label prop mutable
Actions
Copy link
 #6

Updated by Electric Monk almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 469735ec6bb6989760271d57d715d349b93f607f

commit  469735ec6bb6989760271d57d715d349b93f607f
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   2019-01-29T22:13:11.000Z

    10279 ses enumerator should trim leading/trailing whitespace from labels
    10280 ses enumerator module should make protocol/label prop mutable
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF