Project

General

Profile

Bug #10287

qede_ring_tx is too noisy

Added by Robert Mustacchi 11 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
2019-01-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

The qede_ring_tx() function will happily log to the console whenever it it asked to send a packet when the link is down. However this will also happen if a link is not plugged in. On our systems we see this when we don't have all the cables plugged in and lldp is active causing annoying messages to drop to the console too frequently for this authors sanity.

Because this doesn't really tell us anything useful (as it may be down intentionally), it really should just be removed. No other networking driver logs like this.

History

#1

Updated by Electric Monk 10 months ago

  • Status changed from New to Closed

git commit 12c2600ce5fc8bc76606af4f06cc20c56993dcd7

commit  12c2600ce5fc8bc76606af4f06cc20c56993dcd7
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-02-13T19:15:46.000Z

    10287 qede_ring_tx is too noisy
    Reviewed by: Jason King <jason.king@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF