Project

General

Profile

Bug #10297

cyclic_mp_init: cast between incompatible function types

Added by Toomas Soome about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2019-01-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Build error with gcc 8:

    ../../common/os/cyclic.c: In function 'cyclic_mp_init':
    ../../common/os/cyclic.c:3164:26: error: cast between incompatible function types from 'int (*)(cpu_setup_t,  int)' {aka 'int (*)(enum <anonymous>,  int)'} to 'int (*)(cpu_setup_t,  int,  void *)' {aka 'int (*)(enum <anonymous>,  int,  void *)'} [-Werror=cast-function-type]
      register_cpu_setup_func((cpu_setup_func_t *)cyclic_cpu_setup, NULL);
                              ^
    cc1: all warnings being treated as errors

Add missing argument and remove type cast.

History

#1

Updated by Electric Monk 12 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 3ebafc60580cf8a412e554e4babd8c3a0d3e98ea

commit  3ebafc60580cf8a412e554e4babd8c3a0d3e98ea
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-31T22:04:30.000Z

    10297 cyclic_mp_init: cast between incompatible function types
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Hans Rosenfeld <hans.rosenfeld@joyent.com>

Also available in: Atom PDF