Project

General

Profile

Bug #103

illumos.sh - missing ";"

Added by Piotr Jasiukajtis over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Start date:
2010-08-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Tags:
Gerrit CR:

Description

File: usr/src/tools/env/illumos.sh

ON_CRYPTO_BINS="$CODEMGR_WS/on-crypto.$MACH.tar.bz2" export ON_CRYPTO_BINS

should be:
ON_CRYPTO_BINS="$CODEMGR_WS/on-crypto.$MACH.tar.bz2"; export ON_CRYPTO_BINS

#1

Updated by Jeppe Toustrup over 10 years ago

  • Assignee set to Jeppe Toustrup

Also $MACH is not set until later in the script, so the result of ON_CRYPTO_BINS will always be "/code/illumos-gate/on-crypto..tar.bz2".

I'll make a patch for this if nobody else comes first :)

#2

Updated by Jeppe Toustrup over 10 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

I have made a patch for this, webrev is available here: http://cr.illumos.org/view/qetpnsi2/.
Piotr has reviewed the code, and I have tested it on x86 by using bldenv.sh to load the variables were set correctly in the new environment.
The only thing worth testing on SPARC in relation to this, is to verify that "uname -p" does return "sparc", which it does on a T2 Solaris 10 machine I have access to.

The change needs approval before being integrated.

#3

Updated by Gary Mills over 10 years ago

Yes, it's correct for SPARC...

$ uname -i
SUNW,Sun-Fire-480R
$ uname -p
sparc

#4

Updated by Jeppe Toustrup over 10 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Integrated with r13159.

Also available in: Atom PDF