Project

General

Profile

Bug #10302

sed: this statement may fall through

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2019-01-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error from gcc 8:

    main.c: In function 'cu_fgets':
    main.c:237:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (script->type) {
       ^~~~~~
    main.c:257:2: note: here
      case ST_FILE:
      ^~~~
    cc1: all warnings being treated as errors

Add default case.

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 941b7e9c849240e1a04a25b32722d30dae557dc3

commit  941b7e9c849240e1a04a25b32722d30dae557dc3
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-04T16:10:26.000Z

    10302 sed: this statement may fall through
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF