Project

General

Profile

Bug #10310

auditconfig: NULL pointer errors

Added by Toomas Soome 11 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2019-01-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/locale_iso.h:50:0,
                     from /code/illumos-gate/proto/root_i386/usr/include/locale.h:41,
                     from auditconfig.c:29:
    auditconfig.c: In function 'print_mask':
    /code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: passing argument 3 of 'getauditflagschar' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    auditconfig.c:2778:38: note: in expansion of macro 'NULL'
      if (getauditflagschar(auflags, pmp, NULL) < 0)
                                          ^~~~
    In file included from auditconfig.c:53:0:
    /code/illumos-gate/proto/root_i386/usr/include/bsm/libbsm.h:179:12: note: expected 'int' but argument is of type 'void *'
     extern int getauditflagschar(char *, au_mask_t *, int);
                ^~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 10 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit de4cec4850ed6a4d4ee96e179e79e02a3d872ea3

commit  de4cec4850ed6a4d4ee96e179e79e02a3d872ea3
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-04T18:39:11.000Z

    10310 auditconfig: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF