Project

General

Profile

Bug #10312

iasl does not build with bison 3.3

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2019-01-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

/usr/bin/gm4 -P aslparser.y > aslcompiler.y
_suffix=`echo aslcompilerparse.c | awk -F. '{print $NF}'` && \
_d=`mktemp -d AslCompiler.XXXXXX` && \
(cd $_d && /usr/bin/bison -y -v -d -pAslCompiler ../aslcompiler.y) && \
mv $_d/y.tab.$_suffix aslcompilerparse.c; \
_ret=$?; \
rm -rf $_d; \
exit $_ret
../aslcompiler.y:211.1-7: error: POSIX Yacc does not support %expect [-Werror=yacc]
 %expect 124
 ^~~~~~~
*** Error code 1
make: Fatal error: Command failed for target `aslcompilerparse.c'

From the bison 3.3 release notes:

*** 🚨 More POSIX Yacc compatibility warnings

  More Bison specific directives are now reported with -y or -Wyacc.  This
  change was ready since the release of Bison 3.0 in September 2015.  It was
  delayed because Autoconf used to define YACC as `bison -y`, which resulted
  in numerous warnings for Bison users that use the GNU Build System.

History

#1

Updated by Andy Fiddaman 10 months ago

  • Description updated (diff)
#2

Updated by Andy Fiddaman 10 months ago

  • Status changed from In Progress to Pending RTI
  • % Done changed from 0 to 100

Testing notes:

Full nightly builds with bison 3.1, 3.2.4 and 3.3.
Also checked that the resulting iasl binary runs but did not do further tests here.

#3

Updated by Electric Monk 10 months ago

  • Status changed from Pending RTI to Closed

git commit 8b68969e8397fdd77b63574c1184854cbecdb67f

commit  8b68969e8397fdd77b63574c1184854cbecdb67f
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2019-01-29T02:46:40.000Z

    10312 iasl does not build with bison 3.3
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF