Project

General

Profile

Bug #10315

acpi: NULL pointer errors

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2019-01-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    osillumostbl.c: In function 'OslLoadRsdp':
    osillumostbl.c:447:19: error: comparison between pointer and integer [-Werror]
      if (Gbl_RsdpBase != NULL) {
                       ^~
    osillumostbl.c: In function 'OslListBiosTables':
    osillumostbl.c:661:20: error: comparison between pointer and integer [-Werror]
       if (TableAddress == NULL) {
                        ^~
    osillumostbl.c: In function 'OslGetBiosTable':
    osillumostbl.c:810:21: error: comparison between pointer and integer [-Werror]
        if (TableAddress == NULL) {
                         ^~
    osillumostbl.c: In function 'OslMapTable':
    osillumostbl.c:890:14: error: comparison between pointer and integer [-Werror]
      if (Address == NULL) {
                  ^~
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 6eda379352cafb14ed1d54166fe88b67fbefac4d

commit  6eda379352cafb14ed1d54166fe88b67fbefac4d
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-04T18:39:11.000Z

    10315 acpi: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF