Project

General

Profile

Bug #10317

iconv_modules is building with -I/usr/include

Added by Toomas Soome 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2019-01-28
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

from build log:

+ /usr/gcc/7/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -c -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused -Wno-empty-body -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -fno-ipa-icf -fno-clone-functions -fno-reorder-functions -I../../inc -I. -I../../common -fpic -shared -I/usr/include -I../../common/ -I../inc -I.. -I../common/ ../../common/utf8%ibm.c -o utf8%ibm.o 

To fix it, we pick up CPPFLAGS where the proper include path is set already. The annoying part is to handle the compile rules - basically we need to make sure the CPPFLAGS are included.

History

#1

Updated by Electric Monk 11 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 84d9cd0f02f7b6d7963dcb4a84148c3b2aaba7c5

commit  84d9cd0f02f7b6d7963dcb4a84148c3b2aaba7c5
Author: Toomas Soome <tsoome@me.com>
Date:   2019-01-29T20:53:46.000Z

    10317 iconv_modules is building with -I/usr/include
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF