Project

General

Profile

Bug #10321

disk enumerator should make protocol/label prop mutable

Added by Rob Johnston 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2019-01-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Currently the disk topo enumerator sets the protocol/label property via the topo_node_label_set() interface, which defaults to making the label property immutable. The problem with this is that the labels are often sourced from string data read directly from firmware and sometimes these strings can be incorrect or not in a format we prefer. The normal way we'd workaround this would be to override the label via a platform-specific XML file. But because the property has been created with the TOPO_PROP_IMMUTABLE flag, we're not able to fix it up.

So this issue is to track changing the disk enumerator such that it sets the protocol/label property to be mutable on any topo nodes it creates. A similar issue issue exists in the ses enumerator and fixing that is tracked by illumos#10280.

History

#1

Updated by Rob Johnston 10 months ago

  • Subject changed from disk enumerator modules should make protocol/label prop mutable to disk enumerator should make protocol/label prop mutable
#2

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 36f5a109a7ea7c74a4d90af4f589df489e7537c0

commit  36f5a109a7ea7c74a4d90af4f589df489e7537c0
Author: Rob Johnston <rob.johnston@joyent.com>
Date:   2019-03-13T00:08:55.000Z

    10321 disk enumerator should make protocol/label prop mutable
    Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF