Project

General

Profile

Actions
Copy link

Bug #10358

closed

our console should support 256 colors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
kernel
Start date:
2019-02-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The 256 colors (xterm extension) is using \E[38;5;<n>m and \E[48;5;<n>m sequence, where <n> is number from 16 to 255. Since our color is stored in unsigned char, it is easy to implement support for 0-255 colors.

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

For testing I did generate the CSI sequences; amongst others the color_space.pl from https://github.com/robertknight/konsole/blob/master/tests/color-spaces.pl

Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a4e6b9b671bd0b8581ffd85bbc50cdd0bfe18b13

commit  a4e6b9b671bd0b8581ffd85bbc50cdd0bfe18b13
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-15T17:14:29.000Z

    10358 our console should support 256 colors
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF