bfe references random 'halt' symbol
The symbol 'halt' in that condition is not defined from bfe, and is likely the function (the compiler believes it can never be 0, at least).
Updated by Gireesh Nagabhushana almost 9 years ago
Garrett D'Amore wrote:
Looking at this code, it would appear that the reference to "halt" is a left over from an earlier reorganization of this code.
I think it would be safe to just remove the test for halt.
I browsed through the source (and the driver in FreeBSD too). Yes, looks like we can simply remove the check for halt. The variable halt seemed to be used to check whether the chip has already been stopped or not.