Project

General

Profile

Bug #1037

bfe references random 'halt' symbol

Added by Rich Lowe about 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Rich Lowe
Category:
kernel
Start date:
2011-05-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

source:usr/src/uts/common/io/bfe/bfe.c#L2125

The symbol 'halt' in that condition is not defined from bfe, and is likely the function (the compiler believes it can never be 0, at least).

History

#1

Updated by Garrett D'Amore about 9 years ago

Looking at this code, it would appear that the reference to "halt" is a left over from an earlier reorganization of this code.

I think it would be safe to just remove the test for halt.

#2

Updated by Gireesh Nagabhushana almost 9 years ago

Garrett D'Amore wrote:

Looking at this code, it would appear that the reference to "halt" is a left over from an earlier reorganization of this code.

I think it would be safe to just remove the test for halt.

I browsed through the source (and the driver in FreeBSD too). Yes, looks like we can simply remove the check for halt. The variable halt seemed to be used to check whether the chip has already been stopped or not.

#3

Updated by Rich Lowe almost 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Rich Lowe
  • % Done changed from 0 to 70
  • Difficulty changed from Medium to Bite-size
  • Tags deleted (needs-triage)

I have the obvious fix for this on my gcc branch.

#4

Updated by Rich Lowe almost 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

Resolved in r13402 commit:b8164899269e

Also available in: Atom PDF