Bug #1037
closed
bfe references random 'halt' symbol
Added by Rich Lowe about 11 years ago.
Updated almost 11 years ago.
Description
source:usr/src/uts/common/io/bfe/bfe.c#L2125
The symbol 'halt' in that condition is not defined from bfe, and is likely the function (the compiler believes it can never be 0, at least).
Looking at this code, it would appear that the reference to "halt" is a left over from an earlier reorganization of this code.
I think it would be safe to just remove the test for halt.
Garrett D'Amore wrote:
Looking at this code, it would appear that the reference to "halt" is a left over from an earlier reorganization of this code.
I think it would be safe to just remove the test for halt.
I browsed through the source (and the driver in FreeBSD too). Yes, looks like we can simply remove the check for halt. The variable halt seemed to be used to check whether the chip has already been stopped or not.
- Status changed from New to In Progress
- Assignee set to Rich Lowe
- % Done changed from 0 to 70
- Difficulty changed from Medium to Bite-size
- Tags deleted (
needs-triage)
I have the obvious fix for this on my gcc branch.
- Status changed from In Progress to Resolved
- % Done changed from 70 to 100
Resolved in r13402 commit:b8164899269e
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by