Project

General

Profile

Actions
Copy link

Bug #10382

closed

cxgbe: NULL pointer errors

Added by Toomas Soome almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-02-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with NULL pointer:

    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/io/cxgbe/t4nex/t4_sge.c: In function 'get_frame_txinfo':
    ../../../common/sys/null.h:32:14: error: passing argument 2 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2491:21: note: in expansion of macro 'NULL'
       mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                         ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 3 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2491:27: note: in expansion of macro 'NULL'
       mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                               ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 4 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2491:33: note: in expansion of macro 'NULL'
       mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                                     ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 5 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2491:39: note: in expansion of macro 'NULL'
       mac_hcksum_set(m, NULL, NULL, NULL, NULL, txinfo->flags);
                                           ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 2 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2522:23: note: in expansion of macro 'NULL'
         mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                           ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 3 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2522:29: note: in expansion of macro 'NULL'
         mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                                 ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 4 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2522:35: note: in expansion of macro 'NULL'
         mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                                       ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    In file included from ../../../common/sys/param.h:48:0,
                     from ../../../common/sys/t_lock.h:38,
                     from ../../../common/sys/map.h:35,
                     from ../../../common/sys/ddi.h:37,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:23:
    ../../../common/sys/null.h:32:14: error: passing argument 5 of 'mac_hcksum_set' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../../common/io/cxgbe/t4nex/t4_sge.c:2522:41: note: in expansion of macro 'NULL'
         mac_hcksum_set(m, NULL, NULL, NULL, NULL,
                                             ^~~~
    In file included from ../../../common/io/cxgbe/t4nex/adapter.h:27:0,
                     from ../../../common/io/cxgbe/common/common.h:488,
                     from ../../../common/io/cxgbe/t4nex/t4_sge.c:36:
    ../../../common/sys/mac_provider.h:564:15: note: expected 'uint32_t {aka unsigned int}' but argument is of type 'void *'
     extern void   mac_hcksum_set(mblk_t *, uint32_t, uint32_t,
                   ^~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk almost 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 4c028d0b735ed9491ff633b60228498b055778b7

commit  4c028d0b735ed9491ff633b60228498b055778b7
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-15T18:44:50.000Z

    10382 cxgbe: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF