Project

General

Profile

Bug #10390

consms: NULL pointer errors

Added by Toomas Soome 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Build errors with NULL pointer:

    ../../common/io/consms.c: In function 'consms_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/consms.c:277:21: note: in expansion of macro 'NULL'
          0, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                         ^~~~
    In file included from ../../common/io/consms.c:56:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    ../../common/io/consms.c: In function 'consms_new_firm_event':
    ../../common/io/consms.c:976:13: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       fep->pair = NULL;
                 ^
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 10 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 6cd62caa5b5899503c648f5b5ce211b7eec6644d

commit  6cd62caa5b5899503c648f5b5ce211b7eec6644d
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-16T08:16:43.000Z

    10390 consms: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF