Project

General

Profile

Bug #10398

smbios slot version check is broken for smbios 3.x

Added by Robert Mustacchi over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
lib - userland libraries
Start date:
2019-02-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The smbios(1M) command tries to check against the SMBIOS version to determine whether or not it should continue printing data about slots. Unfortunately this version check is encoded incorrectly as it independently checks the major and minor number allowing for a newer version number like 3.1 to fail the 2.6 comparison.

Related issues

Related to illumos gate - Feature #10395: Add support for SMBIOS 3.2Closed2019-02-11

Actions

History

#1

Updated by Robert Mustacchi over 1 year ago

#2

Updated by Electric Monk about 1 year ago

  • Status changed from New to Closed

git commit 1566bc3431383e39ac9bc7fb7f00feff9c06acda

commit  1566bc3431383e39ac9bc7fb7f00feff9c06acda
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-07-09T13:33:41.000Z

    10395 Add support for SMBIOS 3.2
    10396 Want libjedec
    10397 Check for SMBIOS table with higher version
    10398 smbios slot version check is broken for smbios 3.x
    10399 smbios CPU Cache extended size not correctly calculated
    10400 smbios(1M) slot printing could be clearer
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF