Bug #10400
smbios(1M) slot printing could be clearer
Start date:
2019-02-11
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Today, when smbios(1M) prints slot information, it prints a device and function ID that are combined. This ends up making it much harder to read and understand what it is and match it up to other operating system facilities. For example:
... Bus Number: 1 Device/Function Number: 8 ...
Instead, this now looks like:
... Bus Number: 1 Device/Function Number: 1/0 ...
This makes it much clearer about what the device value is and what the function is. It'd be rather hard to know that you should have taken it apart in the past and where to do the mental shift.
Related issues
Updated by Robert Mustacchi almost 2 years ago
- Related to Feature #10395: Add support for SMBIOS 3.2 added
Updated by Electric Monk over 1 year ago
- Status changed from New to Closed
git commit 1566bc3431383e39ac9bc7fb7f00feff9c06acda
commit 1566bc3431383e39ac9bc7fb7f00feff9c06acda
Author: Robert Mustacchi <rm@joyent.com>
Date: 2019-07-09T13:33:41.000Z
10395 Add support for SMBIOS 3.2
10396 Want libjedec
10397 Check for SMBIOS table with higher version
10398 smbios slot version check is broken for smbios 3.x
10399 smbios CPU Cache extended size not correctly calculated
10400 smbios(1M) slot printing could be clearer
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>
Reviewed by: C Fraire <cfraire@me.com>
Approved by: Richard Lowe <richlowe@richlowe.net>