Project

General

Profile

Actions
Copy link

Bug #10402

closed

mergeq: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
tests
Start date:
2019-02-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/time_is
    o.h:49:0,
                     from /code/illumos-gate/proto/root_i386/usr/include/time.h:40,
                     from /code/illumos-gate/proto/root_i386/usr/include/sys/time.h:
    462,
                     from /code/illumos-gate/proto/root_i386/usr/include/sys/select.
    h:53,
                     from /code/illumos-gate/proto/root_i386/usr/include/sys/types.h
    :640,
                     from /code/illumos-gate/usr/src/lib/mergeq/workq.h:23,
                     from wqt.c:24:
    /code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initiali
    zation makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    wqt.c:124:28: note: in expansion of macro 'NULL'
      { "empty", wqt_add, 0, 0, NULL, wqt_empty_args },
                                ^~~~
    /code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near ini
    tialization for 'wq_tests[0].wq_sum')
     #define NULL ((void *)0)
                  ^
    wqt.c:124:28: note: in expansion of macro 'NULL'
      { "empty", wqt_add, 0, 0, NULL, wqt_empty_args },
                                ^~~~
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e37450d909c12d4fcfa77c60705f0c3756a442ac

commit  e37450d909c12d4fcfa77c60705f0c3756a442ac
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-16T08:20:49.000Z

    10402 mergeq: NULL pointer errors
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF