loader: dev_net: correct net_open's interpretation of params
net_open previously casted the first vararg to a char * and this was half-OK: at first, it is passed to netif_open, which would cast it back to the struct devdesc * that it really is and use it properly. It is then strdup()d and used as the netdev_name, which is objectively wrong.
Correct it so that the first vararg is properly casted to a struct devdesc * and the netdev_name gets set properly to make it more clear at a glance that it's not doing something horribly wrong.
Updated by Electric Monk almost 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
commit ca4fa6c7dc905e230456873476b8eef017660b93 Author: Toomas Soome <email@example.com> Date: 2019-02-18T17:56:37.000Z 10411 loader: dev_net: correct net_open's interpretation of params Reviewed by: Gergő Doma <firstname.lastname@example.org> Reviewed by: C Fraire <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>