Project

General

Profile

Bug #10416

zoneadmd leaves trailing comma on link address

Added by Andy Fiddaman 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
zones
Start date:
2019-02-18
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

See zoneadmd/vplat.c.

There is even a comment indicating that the comma should be removed:

        /* over-write last ',' with '\0' */
       zaddr[strnlen(zaddr, zlen) + 1] = '\0';

History

#1

Updated by Andy Fiddaman 5 months ago

Review is at: https://www.illumos.org/rb/r/1485/

Testing:

Wrote a utility to dump the network zone attributes from inside a zone via zone_getattr()

Before:

Datalink            : 6 - test0
    address         :     [172.27.10.100/24,]
    router          :     [172.27.10.254]

After:

Datalink            : 6 - test0
    address         :     [172.27.10.100/24]
    router          :     [172.27.10.254]

and in both cases, automatic IP allocation from the zone's allowed-address property worked properly.

#2

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit af34582fe571c99d9f74acf7c271e26c744fef5b

commit  af34582fe571c99d9f74acf7c271e26c744fef5b
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2019-02-20T21:18:00.000Z

    10416 zoneadmd leaves trailing comma on link address
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF