Project

General

Profile

Actions

Bug #10421

closed

bofi: cast between incompatible function types

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error with gcc 8:

    ../../common/io/bofi.c:3368:19: error: cast between incompatible function types from 'int (*)(char *)' to 'void (*)()' [-Werror=cast-function-type]
        (void) timeout((void (*)())waitfp, arg, 10);
                       ^
    ../../common/io/bofi.c: In function 'bofi_dma_bindhdl':
    ../../common/io/bofi.c:3613:18: error: cast between incompatible function types from 'int (*)()' to 'void (*)()' [-Werror=cast-function-type]
       (void) timeout((void (*)())dmareqp->dmar_fp,
                      ^
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 54bc10fe6ad8a64fc279dc5fba56eaafea7ec2c0

commit  54bc10fe6ad8a64fc279dc5fba56eaafea7ec2c0
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-22T17:40:24.000Z

    10421 bofi: cast between incompatible function types
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions

Also available in: Atom PDF