Project

General

Profile

Bug #10422

conskbd: cast between incompatible function types

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
2019-02-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error with gcc 8:

    ../../common/io/conskbd.c:130:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())conskbduwsrv, /* qi_srvp */
      ^
    ../../common/io/conskbd.c:140:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())conskbdlrput, /* qi_putp */
      ^
    ../../common/io/conskbd.c:152:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())conskbdlwserv, /* qi_srvp */
      ^
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk over 1 year ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit fb05fcb92e04bd3719e79f64be4c3432c2f1a119

commit  fb05fcb92e04bd3719e79f64be4c3432c2f1a119
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-20T22:32:58.000Z

    10422 conskbd: cast between incompatible function types
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF