Project

General

Profile

Actions

Bug #10431

closed

conskbd: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

In file included from ../../common/sys/param.h:48:0,
                 from ../../common/io/conskbd.c:58:
../../common/io/conskbd.c: In function 'conskbd_attach':
../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/io/conskbd.c:458:21: note: in expansion of macro 'NULL'
      0, DDI_PSEUDO, NULL) == DDI_FAILURE) ||
                     ^~~~
In file included from ../../common/io/conskbd.c:69:0:
../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
 ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
 ^~~~~~~~~~~~~~~~~~~~~
../../common/io/conskbd.c: In function 'conskbd_alloc_firm_event':
../../common/io/conskbd.c:1686:12: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   fe->pair = NULL;
            ^
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a897f299fb4fe4ed74ba062d6b8984404d1b94bc

commit  a897f299fb4fe4ed74ba062d6b8984404d1b94bc
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-25T16:58:28.000Z

    10431 conskbd: NULL pointer errors
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF