Project

General

Profile

Bug #10432

devinfo: NULL pointer errors

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

NULL pointer errors:

    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/vnode.h:46,
                     from ../../common/sys/pathname.h:37,
                     from ../../common/io/devinfo.c:30:
    ../../common/io/devinfo.c: In function 'di_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/devinfo.c:464:35: note: in expansion of macro 'NULL'
           DI_FULL_PARENT, DDI_PSEUDO, NULL) == DDI_FAILURE ||
                                       ^~~~
    In file included from ../../common/io/devinfo.c:40:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/vnode.h:46,
                     from ../../common/sys/pathname.h:37,
                     from ../../common/io/devinfo.c:30:
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/devinfo.c:466:39: note: in expansion of macro 'NULL'
           DI_READONLY_PARENT, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                                           ^~~~
    In file included from ../../common/io/devinfo.c:40:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    ../../common/io/devinfo.c: In function 'di_copynode':
    ../../common/io/devinfo.c:1820:24: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
      me->user_private_data = NULL;
                            ^
    ../../common/io/devinfo.c: In function 'di_getmdata':
    ../../common/io/devinfo.c:2539:25: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
       me->user_private_data = NULL;
                             ^
    cc1: all warnings being treated as errors

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 093aa5c8de00cc7b99cc4a2cfaeb7d95115847b7

commit  093aa5c8de00cc7b99cc4a2cfaeb7d95115847b7
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-25T17:17:30.000Z

    10432 devinfo: NULL pointer errors
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF