Project

General

Profile

Actions

Bug #10436

closed

eventfd: NULL pointer errors

Added by Toomas Soome almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

    ../../common/io/eventfd.c: In function 'eventfd_open':
    ../../common/io/eventfd.c:72:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
       return (NULL);
              ^
    In file included from ../../common/sys/param.h:48:0,
                     from ../../common/sys/t_lock.h:38,
                     from ../../common/sys/map.h:35,
                     from ../../common/sys/ddi.h:37,
                     from ../../common/io/eventfd.c:21:
    ../../common/io/eventfd.c: In function 'eventfd_attach':
    ../../common/sys/null.h:32:14: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast [-Werror=int-conversion]
     #define NULL ((void *)0)
                  ^
    ../../common/io/eventfd.c:322:39: note: in expansion of macro 'NULL'
          EVENTFDMNRN_EVENTFD, DDI_PSEUDO, NULL) == DDI_FAILURE) {
                                           ^~~~
    In file included from ../../common/io/eventfd.c:22:0:
    ../../common/sys/sunddi.h:1564:1: note: expected 'int' but argument is of type 'void *'
     ddi_create_minor_node(dev_info_t *dip, char *name, int spec_type,
     ^~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors


Related issues

Related to illumos gate - Bug #6258: eventfd problem with NULL pointer constant and intsClosed2015-09-22

Actions
Actions #1

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3deeb0a9324c13756f519d91f000f0f44058e7b9

commit  3deeb0a9324c13756f519d91f000f0f44058e7b9
Author: Toomas Soome <tsoome@me.com>
Date:   2019-04-05T05:25:20.000Z

    10436 eventfd: NULL pointer errors
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions #2

Updated by Toomas Soome about 1 year ago

  • Related to Bug #6258: eventfd problem with NULL pointer constant and ints added
Actions

Also available in: Atom PDF