Project

General

Profile

Actions

Bug #10437

closed

dca: NULL pointer errors

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2019-02-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

NULL pointer errors:

../../common/crypto/io/dca.c: In function 'dca_attach':
../../common/crypto/io/dca.c:667:32: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  WORKLIST(dca, MCR1)->dwl_prov = NULL;
                                ^
../../common/crypto/io/dca.c:668:32: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  WORKLIST(dca, MCR2)->dwl_prov = NULL;
                                ^
../../common/crypto/io/dca.c:859:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR1)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c:863:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR2)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c: In function 'dca_detach':
../../common/crypto/io/dca.c:928:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR1)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c:936:36: error: comparison between pointer and integer [-Werror]
  if (WORKLIST(dca, MCR2)->dwl_prov != NULL) {
                                    ^~
../../common/crypto/io/dca.c: In function 'dca_uninit':
../../common/crypto/io/dca.c:1246:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   wlp->dwl_prov = NULL;
                 ^
../../common/crypto/io/dca.c: In function 'dca_bindchains':
../../common/crypto/io/dca.c:1930:21: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   reqp->dr_in_paddr = NULL;
                     ^
../../common/crypto/io/dca.c:1963:22: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   reqp->dr_out_paddr = NULL;
                      ^
../../common/crypto/io/dca.c: In function 'dca_unbindchains':
../../common/crypto/io/dca.c:1981:45: error: comparison between pointer and integer [-Werror]
  if (reqp->dr_chain_in_head.dc_buffer_paddr != NULL) {
                                             ^~
../../common/crypto/io/dca.c:1991:46: error: comparison between pointer and integer [-Werror]
  if (reqp->dr_chain_out_head.dc_buffer_paddr != NULL) {
                                              ^~
cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 5c63ad82aeee3300425b5803b5324fd102047957

commit  5c63ad82aeee3300425b5803b5324fd102047957
Author: Toomas Soome <tsoome@me.com>
Date:   2019-02-25T18:01:18.000Z

    10437 dca: NULL pointer errors
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF